[TYPO3-core] RFC #13283: Thumbnail generation broken for PDF files

Steffen Kamper ks at dislabs.de
Thu Feb 25 23:38:12 CET 2010


Hi,

v7 miss align of the phpDoc which was correct in v6 again.

I don't see a reason to set default to -1 as only is checked if frame is 
gt 0.

Why is parameter ommited if frame is 0? Installtool always check
"...pdf_from_imagemagick.pdf"[0] and it works.

It also confuses me that, if $this->noFramePrepended is set, the frame 
should be dropped. It's not clear in this if/elseif

And one more, isn't it possible to show a frame of an anigif with frame 
option?

So sry for my comments, but patch doesn't satisfy me by reading.
I'm sorry that i can't test this as i have problems getting gs into 
action on my windows system.

vg Steffen


More information about the TYPO3-team-core mailing list