[TYPO3-core] RFC #13258: Bugfix: TYPO3 4.2 should work on PHP 5.1 again

[Oliver Hader]

Hi Ernesto,

Am 16.02.10 11:51, schrieb Ernesto Baschny [cron IT]:
> This is an SVN patch request.
> 
> Type: Bugfix
> 
> Bugtracker references:
> http://bugs.typo3.org/view.php?id=13258
> 
> Branches: TYPO3_4-2
> 
> Problem:
> TYPO3 v4.2 was developed with PHP 5.1 in mind, because some major
> commercial Linux distributions (RedHat, CentOS) which long time support
> still ship with it.
> 
> With the minor release of 4.2.11 we broke that rule, by introducing a
> "filter_var()" function to fix a regression to a security fix (rev. 6408
> [1], RFC #12324 [2]).
> 
> This broke several sites that tried to upgrade, which end up downgrading
> back to 4.2.10.
> 
> 
> Solution:
> The filter_var() function can be replaced by a simple "parse_url" and
> checking if the "scheme" is set. This is a valid replacement, because
> after all this is what PHP internally also does with filter_var (I just
> checked the PHP source-code, believe me).
> 
> Attached patch does that.
> 
> I also checked that change with our latests unit tests (in trunk), as
> this functionality is covered by unit tests, and all passed with successed.

I understand the reasons for this patch - however, we have a difference
concerning the PHP version required for TYPO3 4.2 on the download page
and in the NEXT.txt of that version.
* download page tells 5.1.0 [1]
* NEXT.txt tells 5.2.0 [2]

I don't know why NEWS.txt point to PHP 5.2.0 as minimum requirement. Are
there other parts in TYPO3 4.2 that won't work in PHP 5.1.0?

olly


[1] http://typo3.org/download/packages/
[2] https://svn.typo3.org/TYPO3v4/Core/branches/TYPO3_4-2/NEWS.txt
-- 
Oliver Hader
TYPO3 v4 Core Team Leader