[TYPO3-core] RFC #12066: Code cleanup: Add some constants

Benjamin Mack benni at typo3.org
Sun Feb 21 17:08:51 CET 2010


Hey Oli,

well, I don't see the real benefit in have a constant like

+	// a tabulator
+define('TAB', chr(9));
+	// a linefeed
+define('LF', chr(10));
+	// a carriage return
+define('CR', chr(13));
+	// a CR-LF combination
+define('CRLF', CR . LF);
+	// one hour in seconds
+define('ONE_HOUR', 3600);
+	// one day in seconds
+define('ONE_DAY', 86400);
+	// one week in seconds
+define('ONE_WEEK', 604800);

  * it's not really shorter than before
  * it's not namespaced, what if I include a third-party tool that does 
the same?
  * it's limited: "ONE_MINUTE"? Also, everybody can easily do the "60*24*7"

Maybe I just don't get it. Could you help me out here?

All the best,
Benni.


More information about the TYPO3-team-core mailing list