[TYPO3-core] RFC #12180: Speedup t3lib_BEfunc::getRecordPath by using rootline cache

Steffen Ritter info at rs-websystems.de
Sun Feb 21 15:24:47 CET 2010


Steffen Gebert schrieb:
> Hi,
> 
> This is SVN patch request.
> 
> Type: Bugfix / Speed improvement
> 
> Branches: trunk
> 
> BT reference: http://bugs.typo3.org/view.php?id=12180
> 
> Problem:
> t3lib_BEfunc::getRecordPath() calculates its own rootline instead of 
> using the (cached one) from BEgetRootLine()
> 
> Solution:
> use t3lib_BEfunc::BEgetRootLine()
> 
> Note: It would be important for me to be sure, somedy with versioning 
> experience checked this patch.
> I wasn't able to check weather [#VEP#] is correctly outputted, as I 
> don't know, how to get a Versioning Entry Point
> 
> It would be nice, if sb. (Rupert? :)) could measure, if this patch 
> really has a positive effect on BE speed. At least it simplifies the code.
> 
> Regards
> Steffen
> 
+1 testing

+1 on reading with my changes in attached v2:
calling trim($clause) two times in one line does not make sense. 
Furthermore, the $clause might have been trimmed before using it, too.

So I moved the trim() in front of the if-clause.

regards

Steffen
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: 12180_v2.diff
URL: <http://lists.typo3.org/pipermail/typo3-team-core/attachments/20100221/d3a04500/attachment-0001.txt>


More information about the TYPO3-team-core mailing list