[TYPO3-core] RFC #12470: PHP-5.3 error: function define_syslog_variables() is deprecated

[Susanne Moog]

Hi,

Am 04.11.2009 22:40, schrieb Rupert Germann:
> Type: Bugfix
> 
> Bugtracker references:
> http://bugs.typo3.org/view.php?id=12470
> 
> Branches: Trunk
> 
> Problem:
> when something is written to t3lib_div::syslog() the following warning
> is displayed:
> Deprecated: Function define_syslog_variables() is deprecated in
> C:\xampp\xampp\htdocs\typo3\dummy-4.2.9\t3lib\class.t3lib_div.php on
> line 5392
> 
> when this error happens in the exception handler the output shows only:
> Fatal error: Exception thrown without a stack frame in Unknown on line 0
> the uncaught PHP message seems to break the exception handler.
> 
> Solution:
> remove the function call to define_syslog_variables().
> 
> Background:
> define_syslog_variables() initializes all (global) syslog variables. The
> values are taken from constants which are always loaded. In the core
> only the Constants are used, so it's save to simply remove this call.

+1 by reading and testing.

Testcase:

- Using PHP 5.3.1
- setting an invalid db host ("adsda") in the install tool
- setting "systemLog" to "syslog,LOCAL0"
- Getting "Fatal error: Exception thrown without a stack frame in
Unknown on line 0"
- Applied patch
- Works again :)

Best regards,

Susanne