[TYPO3-core] RFC #13283: Thumbnail generation broken for PDF files

[Xavier Perseguers]

Hi Benni,

> Solution:
> Make it right by adding the frame parameter by checking if it is "numeric".

- You assign "false" as default value. I thought we'd to write FALSE
- php doc states that parameter is string, I guess it should be mixed. phpdoc says either '' or a number. Why assigning a boolean as default value?
- missing spaces after commas in method signature (already in original code but we'd say we take advantage of patch to enhance the code)

BTW, what is the output of GD of a negative frame number is given?

Cheers

-- 
Xavier Perseguers
http://xavier.perseguers.ch/en