[TYPO3-core] RFC #13258: Bugfix: TYPO3 4.2 should work on PHP 5.1 again

[Jonas Diemer]

Hi,

I tried 13258-v3.diff and it works well for me -> "+1"

Also, I'd like to urge you to not drop PHP 5.1 support or, more precisely, 
RedHat Enterprise Linux 5 support for Typo3 4.2.x. We (like probably quite a 
few others) rely on this distribution for our servers.

I am saying this because it seems that in 
http://bugs.typo3.org/view.php?id=9719
people agreed to make "pepl-filter" a requirement. However, AFAIK, there is no 
pepl-filter package in RHEL5 and we would really love to avoid having to 
compile and _maintain_ custom packages just to keep typo3 running...

So again, my vote on this patch as it allows us to use Typo3 4.2 on RHEL5.

Regards,
Jonas

PS: I am not subscribed to the list, please CC me in replies.


Martin Kutschker schrieb am 17.02.2010 09:26:
> Dmitry Dulepov schrieb:
>> Hi!
>>
>> On 2010-02-16 14:10:25 +0200, Martin Kutschker said:
>>> As Ernesto said, please reread the code. While there is special
>>> handling for the schemes http, https
>>> and mailto any scheme is valid. After all schemes can be invented any
>>> day.
>> By the way, we could also have a functions_exists() check there to use
>> filter_var when available.
> 
> Good idea. Would make also the awkward comment obsolete.

Good idea too. Here is a new patch which implements the same
functionality as the original filter_var from PHP and only if
"filter_var" does not exist.

Attached are also additional unit tests (for trunk only) which come
straight from the test cases included with the PHP source code
(ext/filter/tests/015.phpt) and which validate the filter_var
FILTER_VALIDATE_URL in PHP. I used those tests to make sure our function
works like the original one.

But still the "fix" only needs to be applied to branch v4.2, as we have
PHP 5.2 requirement in v4.3 anyway. I'll only commit the unit tests to
trunk to have it "documented".

Cheers,
Ernesto