[TYPO3-core] RFC #13258: Bugfix: TYPO3 4.2 should work on PHP 5.1 again

[Steffen Kamper]

Hi,

Ernesto Baschny [cron IT] schrieb:
> Steffen Kamper schrieb am 17.02.2010 12:37:
>> Hi,
>>
>> +1 by reading!
>>
>> 2 questions:
>> the @ is only needed because of possible empty url?
>> why allow scheme "news" ?
> 
> The @ is needed because parse_url will throw a warning if the URL is not
> valid. Which is what we are trying to test in this method, so it makes
> no sense to output the warning and later output "FALSE" also. :)
>
ok

> "news" is supported as all other schemes (also "blalbalba://"). This is
> how filter_var also works.
> 

but you only allow mailto, news and file (beside http(s))

if (!isset($parsed['host']) && !in_array($scheme, array('mailto', 
'news', 'file'))) {

so why allowing news here?

vg Steffen