[TYPO3-core] RFC #13258: Bugfix: TYPO3 4.2 should work on PHP 5.1 again

Marcus Krause marcus#exp2010 at t3sec.info
Tue Feb 16 12:33:49 CET 2010


Am 16.02.2010 12:18, schrieb Ernesto Baschny [cron IT]:
> Hi,
> 
> true! Attached patch fixes the comment.

I'm sorry, I *cannot* give a +1.

This is no quivalent. The check you're aiming to commit is a
"isValidURI" and not "isValidUrl".

The PHP sourcecode in question is here:
http://svn.php.net/viewvc/php/php-src/trunk/ext/filter/logical_filters.c?view=markup

If I'd submit a parameter "mailto:user at example.org" or
"file:///etc/passwd" the function would return TRUE, too.

I think at least an additional scheme comparison (http,https) is
required, too. See PHP sourcecode.


Marcus.


More information about the TYPO3-team-core mailing list