[TYPO3-core] FYI24 #13368: Method filelink of tslib_content uses 'target' instead of 'fileTarget'

[Xavier Perseguers]

Hi,

Will commit this in 24h if nobody objects...

Cheers

On 29.01.2010 14:48, Xavier Perseguers wrote:
> Hi,
>
> This is a SVN patch request.
>
> Type: Bugfix
>
> Branches: trunk, 4-3, 4-2
>
> Bugtracker reference:
> http://bugs.typo3.org/view.php?id=13368
>
> Problem:
>
> Method filelink prepares the typolink configuration with a parameter
> 'target'. However when dealing with files, the "target" attribute should
> be named "fileTarget". See class.tslib_content.php around line 5950:
>
> $target = isset($conf['fileTarget']) ? $conf['fileTarget'] :
> $GLOBALS['TSFE']->fileTarget;
> if ($conf['fileTarget.']) {$target = $this->stdWrap($target,
> $conf['fileTarget.']);}
> if ($forceTarget) {$target=$forceTarget;}
> $this->lastTypoLinkTarget = $target;
>
> Solution:
> Use 'pageTarget' instead for the typolink configuration
>
> How-to reproduce (example):
> Try to configure tt_news to generate links for list of files with a
> target _blank :
>
> plugin.tt_news.newsFiles.target = _blank
>
> The configuration 'newsFiles.' is passed as-this to method filelink().
> Now links are not generated with target "_blank".
>
> Sole solution ATM to have those links opening in a blank browser window
> is to force all filelinks to use a _blank target (with config.fileTarget
> = _blank).
>


-- 
Xavier Perseguers
http://xavier.perseguers.ch/en