[TYPO3-core] RFC #16656 : bug : ImageMagick does not work with quotes in exec() path on Windows

[Jigal van Hemert]

Hi,

On 21-12-2010 17:16, Helmut Hummel wrote:
> Am 21.12.2010 14:40, schrieb Jigal van Hemert:
>>
>> It's not related to escapeshellargs/escapeshellcmd.
>>
>> The problems are:
>> 1. there are installations with spaces in paths to im/gm and/or the
>> images; these need quotes around those paths
>
> That's why escapeshellarg()was added around the im/gm path, but as
> mentioned in #16755 this is wrong and escapeshellcmd would be
> sufficient. Did you test this?

escapeshellcmd() does not add quotes around the argument. So it is 
useless for handling paths to executables with spaces in them.

I don't know all file systems available on Windows, *nix, etc., but if 
one of them allows quotes or double quotes in parts of the path or file 
name these quotes must be escaped. It still feels appropriate to use 
escapeshellarg() for this.

Now that we have t3lib_utility_Command, I've adapted the patch to use 
that class. Attached v2.

-- 
Kind regards / met vriendelijke groet,

Jigal van Hemert
skype:jigal.van.hemert
msn: jigal at xs4all.nl
http://twitter.com/jigalvh
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: 16656_v2.patch
URL: <http://lists.typo3.org/pipermail/typo3-team-core/attachments/20101229/855ebb14/attachment.asc>