[TYPO3-core] FYI #16795: t3lib_div::unQuoteFilenames fails to detect quotes properly

Jigal van Hemert jigal at xs4all.nl
Wed Dec 22 09:26:55 CET 2010


Hi Stan,

On 21-12-2010 20:31, Stanislas Rolland wrote:
>> t3lib_div::unQuoteFilenames fails to detect quotes properly. Because of
>> this issue the parameters which need to be swapped for certain IM/GM
>> commands in certain versions of IM/GM are not correct and image
>> generation is broken.
>
> Be aware that t3lib_div::unQuoteFilenames is also used by
> tslib_cObj::typoLink and by t3lib_parsehtml_proc::TS_links_rte to
> explode typolink parameters. Please make sure these are not broken
> especially when the class parameter is quoted and contains multiple
> classes separated by spaces, and/or when the title parameter contains
> spaces and/or quotes.

Thanks for your warnings about these uses. To make sure the function 
works correctly unit tests were included. Can you check that the cases 
covered in the unit tests are sufficient for handling the typolink 
parameters?

-- 
Kind regards / met vriendelijke groet,

Jigal van Hemert
skype:jigal.van.hemert
msn: jigal at xs4all.nl
http://twitter.com/jigalvh


More information about the TYPO3-team-core mailing list