[TYPO3-core] RFC #16786: Bug: Versioning: Generating preview link not working

François Suter fsu-lists at cobweb.ch
Tue Dec 21 09:55:05 CET 2010


Hi,

> Problem:
> When generating preview-links inside the versioning module, the
> trailing "/" of the view-url is missing. This is because the function
> t3lib_BEfunc::getViewDomain() is now used instead of
> t3lib_div::getIndpEnv('TYPO3_SITE_URL').
>
> Solution:
> Simply added a slash

+1 after reading and testing. Attached a cleaned up v2.

Although the issue also exists in current 4.5 trunk, I wonder if it 
should be fixed, because the "Versioning" module is supposed to be 
removed AFAIK. That being said, the "Generate Workspace Preview Link" of 
the new "Workspaces" module doesn't work, so I don't know. Input from 
the workspaces team would be nice here. Anyway I don't mind applying 
such a simple fix to 4.5 too.

As it's almost a no-brainer, I'm ready to commit it right away, I would 
just like to have some input from the workspaces team first.

Cheers

-- 

Francois Suter
Cobweb Development Sarl - http://www.cobweb.ch
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: 16786_v2.diff
URL: <http://lists.typo3.org/pipermail/typo3-team-core/attachments/20101221/d738495c/attachment.txt>


More information about the TYPO3-team-core mailing list