[TYPO3-core] RFC #16749 lock file double deletion

[Bjoern Pedersen]

Am 16.12.2010 10:16, schrieb Dmitry Dulepov:
> Hi!
> 
> First of all, names of classes cannot be changed like that, without
> prior announcement two versions before the change. Somebody may use that
> class outside of the core. It is in t3lib/, so it is available for
> anybody. -1 to renaming t3lib_lock. This change is breaking, so it may
> not go in.

The "normal" lock class is still named t3lib_lock.

> 
> Next, we do not put many classes to one file. One class per file, please.

Yes that can be done.

> Next, there is a "switch" that works with files and semaphores. To code
> that properly, the class should be split to different classes for each
> locking method. "switch" in such cases is always a sign of wrong design.
> I would create a new lock/ subdirectory inside t3lib and put
> implementation classes there.

That is the old t3lib_lock code. I am not shure wether I find the time
to do that currently.


> Finally, your post lacks RFC title in the subject :)

Yes I saw that, too.
> Dmitry.
>