[TYPO3-core] RFC #12232: Bug: md5_file() to check if a file has been changed is very expensive [performance]

Ernesto Baschny ernesto.baschny at typo3.org
Thu Dec 16 09:36:55 CET 2010


Steffen Gebert schrieb am 13.12.2010 16:13:
>> Hi! Yes, I can write an Upgrade Wizard, I think better do it as a
>> separate RFC after this issue fixed.
> I'm fine with it.
> 
>> By the way making an upgrade wizard means that the patch will go to
>> trunk only, right?
> Yes, of course.
> 
> As already mentioned (IIRC), it's IMHO too late for 4.5-trunk, I think
> we should wait with this change after the release of 4.5. Nevertheless,
> I'd be happy to see the patches soon to bring them in after branching.

This is a performance issue which can still be included in 4.5-trunk.
This cannot go in 4.4 anyway because of the change of behavior
(performance fix is not a bug fix).

Since the calculation of the md5 hash will be changed (meaning old
hashes are wrong) an Upgrade Wizard would be a nice addition, as it
seems possible to recalculate them very fast by just going through the
existing table and checking each file's mtime + size.

Cheers,
Ernesto

-- 
Ernesto Baschny
Core Developer V4 Team
Release Manager TYPO3 4.5

TYPO3 .... inspiring people to share!
Get involved: typo3.org


More information about the TYPO3-team-core mailing list