[TYPO3-core] RFC #16574: Bug/Cleanup: PHP notices from XCLASS inclusions

Susanne Moog typo3 at susannemoog.de
Fri Dec 3 13:38:32 CET 2010


REMINDER #1

On 26.11.2010 14:53, Susanne Moog wrote:
> On 26.11.2010 12:54, Susanne Moog wrote:
>> Hey,
>>
>> This is an SVN patch request.
>>
>> Type: bug / cleanup
>>
>> Bugtracker references:
>> http://bugs.typo3.org/view.php?id=16574
>>
>> Branches:
>> trunk
>>
>> Problem:
>> The default XCLASS inclusion generates PHP notices as it uses
>> $TYPO3_CONF_VARS and tries to access undefined array indexes.
>>
>> Solution:
>> Fix by using $GLOBALS['TYPO3_CONF_VARS'] and isset()
>>
>> Notes / How to test:
>> Apply the patch and see that everything including XClasses still works.
>> I additionally checked for syntax errors by using "find ./ -name '*.php'
>> | xargs -I% /usr/bin/php -l %"
>>
> 
> ok, here is v3 taking all comments into account (thanks Oli, for the
> regex ;))
> 
> I already divided the patch like Steffen said.
> 
> Susanne
> 


-- 
What's worth the price is always worth the fight
Every second counts 'cause there's no second try

TYPO3 Core Team Member


More information about the TYPO3-team-core mailing list