[TYPO3-core] RFC #15794: Bug "File -> List shown even though extension not installed : Bug: "Close window and check dependencies" doesn't work anymore"

[Søren Malling]

Hi Ernesto,

Thanks very much for information about best practise in core :)

As this patch is totally different from my original, i hope that my

+1 on reading and testing

is accepted for this RFC

Best regards,

Søren Malling

TYPO3 Brugergruppe Danmark: www.typo3danmark.dk
Twitter: twitter.com/sorenmalling



On Wed, Dec 1, 2010 at 6:25 PM, Ernesto Baschny [cron IT]
<ernst at cron-it.de> wrote:
> Hi Soren,
>
> thanks for finding that uglyness. But the solution seems like a "hack".
> It would be better if the new sysext register themselves in $TBE_MODULES
> just like any other extension would do, without the
> t3lib/stddb/tables.php having to do that "dirty job".
>
> I just took a look at it, and it seems the extensions already register
> themselves as modules, so we just need to get rid of the hardcoded
> values in t3lib/stddb/tables.php.
>
> Then we are sometimes left with an "empty" top level menu (File without
> Filelist installed). This was made so that extensions like "ll-xml"
> still work. So a tiny fix when detecting which top level menu to still
> display is needed (in typo3/classes/class.modulemenu.php).
>
> Attached patch does both things.
>
> To test simply uninstall File>Filelist or Web>Info or Web>Access and see
> the modules disappearing from the menu.
>
> One uglyness is left: The "Workspaces" module adds its module
> "before:info". If you uninstall the "Web>Info" extension, then
> Workspaces is placed on TOP of the Web module. But this is out of scope
> of *this* issue. :)
>
> Cheers,
> Ernesto
>
> Søren Malling schrieb am 24.09.2010 15:18:
>> Attached a new diff which works (hopefully :P) for all the
>> sysextestions (not marked as required in ext. mgm.) from
>> stddb/tables.php (line 444).
>>
>> Please ignore the first patch as it was only made for EXT:filelist,
>> but the issue was of course related to any of the new sysextensions.
>>
>> Søren Malling
>>
>> Twitter: twitter.com/sorenmalling
>>
>>
>>
>> On Fri, Sep 24, 2010 at 2:14 PM, Søren Malling <soren.malling at gmail.com> wrote:
>>> Please wait with reveiwing this patch.
>>>
>>> Spoke with Steffen G, and the check should also be made for the other
>>> new sys extensions.
>>>
>>> Will send a new patch ASAP
>>>
>>> Søren Malling
>>>
>>> Twitter: twitter.com/sorenmalling
>>>
>>>
>>>
>>> On Fri, Sep 24, 2010 at 2:03 PM, Søren Malling <soren.malling at gmail.com> wrote:
>>>> This is an SVN patch request.
>>>>
>>>> Type: Bugfix
>>>>
>>>> Bugtracker references:
>>>> http://bugs.typo3.org/view.php?id=15794
>>>>
>>>> Branches:
>>>> trunk
>>>>
>>>> Problem:
>>>> File -> List shown even though extension not installed
>>>>
>>>> Solution:
>>>> Check if EXT:filelist is loaded, and hide the module if it's not
>>>>
>>>> Notes:
>>>> Decided to split the array into single line for each key. This was in
>>>> order to make conditional check. Is this CGL valid?
>>>>
>>>> Søren Malling
>>>>
>>>> Twitter: twitter.com/sorenmalling
>>>>
>>>> _______________________________________________
>>>> Before posting to this list, please have a look to the posting rules
>>>> on the following websites:
>>>>
>>>> http://typo3.org/teams/core/core-mailinglist-rules/
>>>> http://typo3.org/development/bug-fixing/diff-and-patch/
>>>> _______________________________________________
>>>> TYPO3-team-core mailing list
>>>> TYPO3-team-core at lists.typo3.org
>>>> http://lists.typo3.org/cgi-bin/mailman/listinfo/typo3-team-core
>>>>
>>> _______________________________________________
>>> Before posting to this list, please have a look to the posting rules
>>> on the following websites:
>>>
>>> http://typo3.org/teams/core/core-mailinglist-rules/
>>> http://typo3.org/development/bug-fixing/diff-and-patch/
>>> _______________________________________________
>>> TYPO3-team-core mailing list
>>> TYPO3-team-core at lists.typo3.org
>>> http://lists.typo3.org/cgi-bin/mailman/listinfo/typo3-team-core
>>>
>
>
> _______________________________________________
> Before posting to this list, please have a look to the posting rules
> on the following websites:
>
> http://typo3.org/teams/core/core-mailinglist-rules/
> http://typo3.org/development/bug-fixing/diff-and-patch/
> _______________________________________________
> TYPO3-team-core mailing list
> TYPO3-team-core at lists.typo3.org
> http://lists.typo3.org/cgi-bin/mailman/listinfo/typo3-team-core
>