[TYPO3-core] RFC: #10118: Make pi_wrapInBaseClass wraps configurable

[Ingo Renner]

Jigal van Hemert wrote:

Hi Jigal,

> This is where you've lost me. The disabling part I understand, but how
> to enable it?
> config.pluginWrap = 1

this isn't needed, it's implied that it's on by default.

> config.pluginWrap.wrap = <li>|</li>

I think it's intended to work like this (from what I understood from the 
previou patches and approaches):
config.pluginWrap = <li>|</li>

>
> (whitespace reduced for line width)
> // global wrap overriding default wrap
> if (!empty($GLOBALS['TSFE']->config['config']['pluginWrap'])) {
> $pluginWrap = $this->cObj->stdWrap(
> $GLOBALS['TSFE']->config['config']['pluginWrap'],
> $GLOBALS['TSFE']->config['config']['pluginWrap.']
> );
> }
>
> (Also ['config'] should be ['config.'], right?)

upps, yes. As I said, I haven't tested it... wrote this on a two hour 
train ride... :)

> This will turn my setting into:
> $pluginWrap = <li>1</li>


> At the end this is applied as wrap, so to make it work I must set
> config.pluginWrap = |
> which is quite odd.

... need to test it myself ;)

> Why not have pluginWrap = 1 to activate and override and use the entire
> ['config']['pluginWrap.'] as stdWrap configuration?

  * pluginWrap = 1 is implied by default to have it active at all times, 
for backwards compatibility
  * pluginWrap. should be stdWrap already

> In that case the default must be like
> $pluginWrap = array( 'wrap' => '<div class=........|</div>');
> and the prefixComment can be applied separatedly at the end of the
> function.

wanna adapt the patch?


best
Ingo

-- 
Ingo Renner
TYPO3 Core Developer, Release Manager TYPO3 4.2