[TYPO3-core] RFC: #15576: Enable customization for the backend and frontend fatal error messages

[Steffen Gebert]

Am 27.08.10 14:27, schrieb Reinhard Führicht:
> Bugtracker reference:
> http://bugs.typo3.org/view.php?id=15576
>
> Branches:
> Trunk
>
> Problem:
> The error screens like "The current username, password or host was not
> accepted ..." are not customizable. The image shown could be set in
> $TBE_STYLES in PHP, but is not changeable in the install tool.

Hi Reinhard,

thanks for your patch. In principle a big "YES, finally! (somebody 
cared)" ;-)

A few things, which prevent a positive review:

* 'errorMessageLogo' => TYPO3_maindir . 'gfx/typo3logo.gif'
   - has to be TYPO3_mainDir
   - -1 for a config option for this, IMHO the option to defina a custom
     template should be sufficient

* changing signature of
   function·debug_typo3PrintError($header,·$text,·$js,·$baseUrl·=·'')
   You're removing a feature - to print the error message in an alert
   box.

* naming of typo3PrintError()
   I'm strongly against reusing this name! Maybe printError() or similar.

* the most important point, while we're at changing this functionality:
   Long-term plan is to throw exceptions everywhere and get rid of
   typo3PrintError(), isn't it?
   IIRC the production exception/error handler calls typo3PrintError().
   What do you think of modifiying this error handler and implement the
   functionality there? While deprecation phase, t3PE() can throw an
   exception, until it's removed.

* CGL and nitchpicking:
   - Please uses spaces after "if" before the (
   - only one space after a comment (not //  prepend "/")
   - no tabs in "empty" lines
     so maybe you could enable your IDE to show white-space chars while
     you're at core developement? ;-)
   - use uppercase for boolean values TRUE/FALSE
   - $logo·=·'<img·src="'·.·$imageSrc·.·'"·/>';
     where's the alt="Logo" or similar ;-)
   - print·$errorMessage;
     why print? we use echo everywhere. For the sake of consistency I'd
     keep echo. Or is there any advantage?

Attached is a cleaned patch (CGL and so on changed), to continue working.

Thanks for your efforts, Reinhard!

Kind regards
Steffen

-- 
Steffen Gebert
TYPO3 Core Team Member
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 15576_v2.diff
Type: text/x-diff
Size: 10814 bytes
Desc: not available
URL: <http://lists.typo3.org/pipermail/typo3-team-core/attachments/20100827/355ed843/attachment-0001.diff>