[TYPO3-core] RFC #15457: Add support for prepared queries [summary and pending questions]

[Helmut Hummel]

Hi,

On 19.08.10 21:01, Xavier Perseguers wrote:
> 
>> Xavier, if you don't have anything against it, could we agree on that
>> minor follow-up, as the new API is still fresh?
>>
>> So magic also on "NULL", else we won't be able to write "NULL" string to
>> the DB:
>>
>> if (is_bool($value)) {
>>     $type = self::PARAM_BOOL;
>> } elseif (is_int($value)) {
>>     $type = self::PARAM_INT;
>> } elseif (is_null($value)) {
>>     $type = self::PARAM_NULL;
>> } else {
>>     $type = self::PARAM_STR;
>> }
>>
>> Agreed?
> 
> Yes.
> 
> Attached patch committed to trunk as follow-up (rev. 8626).

Thanks for the great work on that.

While writing unit tests for the new preparedStatement class, I found a
bug. Named parameters will not get replaced, if passed to execute().

Find the fix attached.

Regards Helmut
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 15457_followup_2.diff
Type: text/x-patch
Size: 608 bytes
Desc: not available
URL: <http://lists.typo3.org/pipermail/typo3-team-core/attachments/20100819/c755f8aa/attachment-0001.bin>