[TYPO3-core] RFC #15457: Add support for prepared queries

Helmut Hummel helmut at typo3.org
Tue Aug 17 01:21:04 CEST 2010


On 16.08.10 22:21, Xavier Perseguers wrote:
> Hi,
> 
> Please find v3 attached.

Awsome! Thanks for that.

Only one comment and one question:

I'm not too comfortable with the is_numeric() checks, because what
really is meant is what t3lib_div::testInt() delivers; a check for
integer. But is_numeric('1.234') also evaluates to true. The least thing
I would do, is add a intval() in replaceValuesInQuery() when type is
PARAM_INT. But why not enforcing the use of correct integer type and
checking it with is_int()? Any downsides?

Besides that, +1 by reading, testing will follow.

Now that we will have prepare_SELECTquery(), are there plans for
prepare_INSERTquery() etc. ? :)


Regards Helmut


More information about the TYPO3-team-core mailing list