[TYPO3-core] RFC #15457: Add support for prepared queries

Steffen Kamper info at sk-typo3.de
Sat Aug 14 23:47:22 CEST 2010


Hi Xavier,

fantastic, i love to see that!

Here are some annotations from reading:

is there a reason why you used 5 and 10 for BOOL and AUTOTYPE?

i don't like the naming of stmt_execute (too cryptic abbreviation). Why 
not preparedQuery_execute, or like the others exec_PREPAREDquery

* $key = is_numeric($parameter) ? intval($parameter) - 1 : $parameter;
why -1 ? why not use (string) $parameter always?

why choosing "thaw"? I looked up the translation but can't associate 
what is meant.

what happen ig thawValuesInQuery is called without PARAM_AUTOTYPE and 
wrong type?

$stmt - see above, better naming

if ($parameterReferences == NULL) {
use strict here

protected function &getValueOrParameter(...
why is the reference here? Could you add this to the description?

I also don't know the parser very well, so can you explain how 
parameterReferences are filled? Maybe related to last mentioned function?

For testing i would like to see unit tests using the prepared 
statements, would make it much easier ;)

Thanks for your great work and sry for the nitpicking.

vg Steffen



More information about the TYPO3-team-core mailing list