[TYPO3-core] RFC: #15440: isFirstPartOfStr doesn't work with non-strings

[Christian Kuhn]

Steffen Kamper wrote:
> sry - totally forgot #15002 which does the performance improvement.

Yes, and please add kudos to Michiel Roos, he was the original submitter 
and did the main work.


> So i combined it, see attached v2.
> Only difference to latest solution in #15002 is the non-strict compare 
> and the string cast.

+1 on reading and testing (very minor modifications attached).

After reading and benching through #15002 again, I'm fine with the two 
casts: On one hand they harden the method a bit, on the other hand they 
really don't cost that much, it's still much quicker than the current 
solution.

Regards
Christian
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 15440_v3.diff
Type: text/x-patch
Size: 824 bytes
Desc: not available
URL: <http://lists.typo3.org/pipermail/typo3-team-core/attachments/20100812/54d0f6e7/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 15440_v3_test.diff
Type: text/x-patch
Size: 939 bytes
Desc: not available
URL: <http://lists.typo3.org/pipermail/typo3-team-core/attachments/20100812/54d0f6e7/attachment-0001.bin>