[TYPO3-core] RFC: #15440: isFirstPartOfStr doesn't work with non-strings
Jigal van Hemert
jigal at xs4all.nl
Thu Aug 12 15:48:36 CEST 2010
On 12-8-2010 15:05, Steffen Kamper wrote:
> Hi,
>
> sry - totally forgot #15002 which does the performance improvement.
>
> So i combined it, see attached v2.
> Only difference to latest solution in #15002 is the non-strict compare
> and the string cast.
Now that you mention #15002, I would expect it to return FALSE if either
parameter is not a string.
This patch survives the unit tests, but are they correct?
I have to revert my +1 for now until there is consensus about the
question whether parameter types in the API should be enforced or
corrected automatically.
--
Jigal van Hemert
skype:jigal.van.hemert
msn: jigal at xs4all.nl
http://twitter.com/jigalvh
More information about the TYPO3-team-core
mailing list