[TYPO3-core] RFC #15395: Code cleanup for t3lib_compressor

Bernhard Kraft kraftb at think-open.at
Tue Aug 10 00:55:23 CEST 2010


Hello Steffen,


In your patch you have the line:

+	$this->gzipCompressionLevel = intval($compressionLevel);

Which sets the compression level to a class variable. And later on the 
line which uses this variable:

+	t3lib_div::writeFile(PATH_site . $filename . '.gzip', 
gzencode($contents, $this->gzCompressionlevel));

But you assign it to "gzipCompressionLevel" and then use 
"gzCompressionlevel" ... this won't work.

I suggest using "gzipCompressionLevel" in both cases. Attached a fixed 
patch.


greets,
Bernhard
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 15395_v2.diff
Type: text/x-patch
Size: 1075 bytes
Desc: not available
URL: <http://lists.typo3.org/pipermail/typo3-team-core/attachments/20100810/4f1c0fbb/attachment.bin>


More information about the TYPO3-team-core mailing list