[TYPO3-core] RFC #14982: Save and view only working with content and pages

Christian Kuhn lolli at schwarzbu.ch
Sun Aug 8 21:20:00 CEST 2010


Hey,

Ingo Schmitt wrote:
> Add common.table.$table.FePreviewPid as new PageTSconfig for configuring 
> the prevewPID and add hook for manipulating the URL, e.g. for adding 
> additional parameters for detail-view.
> Unittest for the hook is included, see Notes.

minor updates with v4:
- Add isset() to hook and pageTS param to prevent NOTICE level php 
warnings (we already have enough of them ;)
- Fix typo 'editcont'
- Have more fun with unit tests: 1 additional test, 2 add. callbacks

Why my +1 on reading and testing is still missing:
- I know there is some page / userTS to view a different page on click 
on a sysfolder (where can I find it?). Do we really need to introduce 
another "common." namespace here?
- Documentation for new pageTS is missing
- The TS setting only works with "edit", but not "new". Any reason for that?

Thus, +1 on reading and testing for the hook part, but not for the TS 
settings, yet.

Regards
Christian
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 14983_v4.diff
Type: text/x-patch
Size: 2369 bytes
Desc: not available
URL: <http://lists.typo3.org/pipermail/typo3-team-core/attachments/20100808/a9933dfe/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 14983_v4_test.diff
Type: text/x-patch
Size: 3944 bytes
Desc: not available
URL: <http://lists.typo3.org/pipermail/typo3-team-core/attachments/20100808/a9933dfe/attachment-0001.bin>


More information about the TYPO3-team-core mailing list