[TYPO3-core] RFC #15395: Code cleanup for t3lib_compressor

Christian Kuhn lolli at schwarzbu.ch
Sun Aug 8 18:24:46 CEST 2010


Steffen Gebert wrote:
> Branches:
> trunk

Imho 4.4 as well.

> Solution:
> Read the already calculated value

+1 on reading if you fix this:

t3lib_div::writeFile(PATH_site . $filename . '.gzip', 
gzencode($contents, $this->gzCompressionlevel));
                            ^^
                            gzip

BTW: It should be pretty easy to unit test if compression is *really* 
performed, take a look at (pending) #15141, I've done something similar 
there. As a bonus, this will lead to a +1 on testing from me :P

Regards
Christian


More information about the TYPO3-team-core mailing list