[TYPO3-core] RFC #15265: InstallTool-login not possible after Update to 4.4.1 due to session_start() in extensions

[Oliver Hader]

Hi,

Am 02.08.10 21:10, schrieb Helmut Hummel:
> Hi Ernesto,
> 
> thanks for doing the work on the nicer error messages!
> 
> On 02.08.10 18:15, Jeff Segars wrote:
>> On 8/2/10 6:43 AM, Ernesto Baschny [cron IT] wrote:
>>>
>>> Solution:
>>> The attached patches adds a nice message giving the user a hint on where
>>> to look for. In 4.4 and later it is nicely formatted using the same
>>> template as the "The Install Tool is locked" message, in previous
>>> versions it doesn't use any template.
>>
>> +1 on reading and testing with trunk.
>>
>> The styling for the code inside the <pre> tag is really, really small
>> but that should be unrelated to this patch.
>>
>> It seems like the error messages could be a little more user friendly as
>> well...maybe just some more detail about why there's an error. That
>> certainly shouldn't hold up the commit as its far better than the
>> current situation. I'll post back here if I have a chance to come up
>> with some extra text.
> 
> I agree that this can be improved in a later commit.
> 
> However I think that the whole error message handling does not belong to
> the session class, so I rewrote the patch a bit.
> I removed the introduced method and property and throw an exeption
> instead, which gives the benefit that the earlier die could also benefit
> from the nice error output then.
> 
> Attached new patches for 4.2 to trunk, since 4.1 needs to work with PHP4
> and no Exceptions are available there, the patch from Ernesto can be used.
> 
> Besides that +1 on reading and testing on 4-4, 4-3, 4-2

+1 by reading and testing in all branches and trunk

For the 4.1 patch (by Ernesto) I removed the "public" definition of the
getErrorCreationMessage() method. For the other patches (by Helmut) I
added the "protected" definition for method outputErrorAndExit().

olly
-- 
Oliver Hader
TYPO3 v4 Core Team Leader