[TYPO3-core] RFC: Bug #13194: tx_scheduler_CronCmd does not correctly parse step values

[Christian Kuhn]

Attached v2.


Oliver Klee wrote:
 >> +			$resultList = array_merge($resultList, $this->getListPart($part, 
$min, $max));
 >
 > You can use + instead of array_merge.

I like array_merge better as it's much more verbose.


>> +			list($defList, $stepDef) = t3lib_div::trimExplode('/', $definition);
> 
> I don't find the "list" command very easy to read ... is there a way to
> write the same code in another way?

I don't like list() either, especially if more than two values are 
involved. In this case I think the list() call are straight forward and 
still readable enough. I didn't change this.

Regards
Christian
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 13194_02.diff
Type: text/x-patch
Size: 3872 bytes
Desc: not available
URL: <http://lists.typo3.org/pipermail/typo3-team-core/attachments/20100430/1fb6dc5f/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 13194_02_test.diff
Type: text/x-patch
Size: 3293 bytes
Desc: not available
URL: <http://lists.typo3.org/pipermail/typo3-team-core/attachments/20100430/1fb6dc5f/attachment-0001.bin>