[TYPO3-core] RFC #13758: Bug: page.jsInline / page.jsFooterInline may fail with config.removeDefaultJS=external

Steffen Ritter info at rs-websystems.de
Fri Apr 30 10:24:55 CEST 2010


Am 10.04.2010 23:44, schrieb Steffen Kamper:
> Hi,
>
> +1 by reading. Please, as Benni mentioned, add comments to the code
> because like this nobody will get the sense what happens here.
>
> And, while you are in, please use CGL.
>
> Could you provide a simple testcase for the patch? Thx.
>
> vg Steffen
Attached patch v3

  - moves logic to external function
  - introduces a big comment about what happens and why
  - should apply to cgl


core +1 testing is missing


regards

Steffen
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: rfc13758-inlineJS_v3.diff
URL: <http://lists.typo3.org/pipermail/typo3-team-core/attachments/20100430/5d52d713/attachment.asc>


More information about the TYPO3-team-core mailing list