[TYPO3-core] FYI48: #14207: Duplicate submodule URL in JavaScript

Dmitry Dulepov dmitry.dulepov at gmail.com
Mon Apr 26 16:47:15 CEST 2010


Hi!

This is SVN patch request.

Type: bug, trivial

Branches: 4.2, 4.3, 4.4

BT reference: http://bugs.typo3.org/view.php?id=14207

Problem: If module has a navScript URL in conf.php and submodule have a
navScript URL too, JavaScript ends up with a double URL. For example, for
DAM it becomes:

ext/dam/mod_main/tx_dam_navframe.php?ext/dam/mod_main/tx_dam_navframe.php

If you supply parameters to navScript URL, it will be even more funny:

ext/dam/mod_main/tx_dam_navframe.php?ext/dam/mod_main/tx_dam_navframe.php?&folderOnly=1

(notice a second question mark => invalid URL!)

The problem is that getGotoModuleJavascript() appends submodule URL to
itself. Looks like a trivial night coding error :)

Solution: remove the duplicate with its misleading comment. No, there is no
GET parameters to append there (in structure) if you are wondering ;)

Notes:
- tested in FF3 with all web, file, user, admin tools and DAM modules.
Works fine, no side effects!
- this bug fix would be good to have for bugfix
http://bugs.typo3.org/view.php?id=8695

-- 
Dmitry Dulepov
TYPO3 expert / TYPO3 security team member
Twitter: http://twitter.com/dmitryd
Read more @ http://dmitry-dulepov.com/
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: 14207.diff
URL: <http://lists.typo3.org/pipermail/typo3-team-core/attachments/20100426/bd06874c/attachment.asc>


More information about the TYPO3-team-core mailing list