[TYPO3-core] RFC: Bug #13194: tx_scheduler_CronCmd does not correctly parse step values

Christian Kuhn lolli at schwarzbu.ch
Sun Apr 25 16:23:40 CEST 2010


This is a SVN patch request.

Type: bugfix

Branches: trunk

BT: http://bugs.typo3.org/view.php?id=13194

Problem:
Step values of cron command are not always calculated correctly:
* * */14 * * should result in days 14,28
* * 2,4-5,*/14 * * should result in days 2,4,5,14,28

Solution:
Fix the calculation.

Notes:
I found the recursive method getList() pretty hard to understand and 
refactored it a bit to be better readable. It's now splitted into two 
methods: getList() just explodes comma seperated lists and feeds the 
parts to a separate method which does the main magic.

This change is again covered by unit tests.


Regards
Christian
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 13194_01.diff
Type: text/x-patch
Size: 3280 bytes
Desc: not available
URL: <http://lists.typo3.org/pipermail/typo3-team-core/attachments/20100425/210b277c/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 13194_01_test.diff
Type: text/x-patch
Size: 1960 bytes
Desc: not available
URL: <http://lists.typo3.org/pipermail/typo3-team-core/attachments/20100425/210b277c/attachment-0001.bin>


More information about the TYPO3-team-core mailing list