[TYPO3-core] RFC #12908: Bug: wrong distance between image rows [css styled content]

Ernesto Baschny [cron IT] ernst at cron-it.de
Thu Apr 22 11:38:50 CEST 2010


Susanne Moog schrieb am 22.04.2010 09:40:
> Hi Helmut,
> 
> On 21.04.2010 09:43, Helmut Hummel wrote:
>> sorry I did not understand what exactly is wrong. Could you provide a
>> descriptive screenshot?
> 
> You can see in the attached screenshot, that there is some space below
> the image that is not the image itself and not its margin. Setting
> vertical-align:bottom resolves the problem.
> 
>> I only found that the current intext-left rendering (plain 4-3
>> installation) is completely broken in FF 3.6 (see attached screenshots),
>> but this is not related to this RFC, right?
> 
> No... and I haven't seen it broken in my installations. Hm, I'll have a
> look.

This is a bug I already mentioned. It comes from the "CSS hack"
introduced in #10768 [1]. See my note there and the screenshots that
show exactly the same stuff Helmut noticed.

Changing CSC's CSS because "it works here and there" is always risky,
because every CSS hack might come with a penalty of not working on
specific sites.

What is even worse is that the fix of #10768 was applied to all previous
static templates (v3.9, v4.2, v4.3), thus the user cannot even choose to
load previous 4.0 setup to get a working setup, because it was broken
there too.

The same rationale applies to this #12908: I wouldn't have commited it
to the 4.3 branch and in trunk not apply it to the v4.3 static
templates. Because this might BREAK existing sites on a minor update!
This is bad.

These kind of stuff is a "change of behaviour" in my eyes, and should
require a major upgrade. A hint on how to solve it in older sites (by
adding specific CSS lines into the sites CSS) is enough for older sites.

Can we have that as a policy for future changes?

Cheers,
Ernesto

[1] http://bugs.typo3.org/view.php?id=10768


More information about the TYPO3-team-core mailing list