[TYPO3-core] RFC #13858: IS cannot not index files if absRefPrefix is set and indexExternalURLs is not

[Christian Kuhn]

Hey.

Dmitry Dulepov wrote:
> Here is v3, which (1) fixes relative paths, (2) resolves backpaths, (3)
> adds phpUnit tests for easier testing.

Thanks for the testcases! +1 on reading and testing with minor changes 
in v4:

- Comment in test line 113 should be 'relative' ;)
- test methods testNonExistingLocalPath() and testLocalPathWithT3Vars() 
must be public
- test method testLocalPathWithT3Vars() must use t3lib_div::shortMD5 
instead of md5
- test method testLocalPathWithT3Vars() must either not include 
PATH_site in its tested filename, or the indexer code needs to be 
changed here again to allow absolute pathes for this method (and not add 
PATH_site itself). I'm not too sure here, because this feature is afaik 
documented nowhere?! Should 'indexLocalFiles' contain absolute pathes? 
Either way my vote stands up, I'm pretty sure this never worked before 
anyway ;)

Who is around for a second review?

Regards
Christian
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 13858_v4.diff
Type: text/x-patch
Size: 11867 bytes
Desc: not available
URL: <http://lists.typo3.org/pipermail/typo3-team-core/attachments/20100419/d09ee770/attachment-0001.bin>