[TYPO3-core] RFC: Bug #14116: Selecting/deselecting all records does not work with translated records

Steffen Kamper info at sk-typo3.de
Mon Apr 19 20:53:21 CEST 2010


Hi,

Christian Kuhn schrieb:
>> deselect all on second click doesn't work.
> 
> Which happens only if you have more translation records than parent 
> records, so the weird compare calculation "unset if more than half of 
> the records is selected, set otherwise" (var flag = notChecked*2>total;) 
> will fail.
> 
> Maybe we should change this "feature" anyway to something more 
> predictable (eg: unset if all is set, set otherwise)
> 

now i see why. I agree, the complete calculating for selecting 
checkboxes (original code from rev 20) is ...

As we already use good working and simple code in install tool i will 
refactore this part and will come with a patch simply select/deselect 
all without counting selects.

vg Steffen


More information about the TYPO3-team-core mailing list