[TYPO3-core] FYI24: #14149: tslib_cObj::getTreeList() incorrectly checks cache entries

[Dmitry Dulepov]

Hi!

This is SVN patch request.

Type: bug + performance

Branches: 4.3, 4.4

BT reference: http://bugs.typo3.org/view.php?id=14149

Problem: The function fetches cache data and checks if the first row's
"treelist" field is not empty. It does not check if there were any rows at
all. There are two problems with this approach: (1) using non–existing
array in many cases and (2) doing unnecessary queries if there are no
subpages of the page. In case of problem #2 it will also cause SQL warning
about duplicate keys.

Solution: the fix would simply check if rows are returned at all. If they
are, return the result. This is what caches for :)

-- 
Dmitry Dulepov
TYPO3 expert / TYPO3 security team member
Read more @ http://dmitry-dulepov.com/
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: 14149.diff
URL: <http://lists.typo3.org/pipermail/typo3-team-core/attachments/20100419/a251747c/attachment.txt>