[TYPO3-core] RFC #12502: Feature: Use HMACs for authenticity and integrity checks

[Helmut Hummel]

Hi Marcus,

On 16.04.10 18:48, Marcus Krause wrote:
> Marcus Krause schrieb am 04/16/2010 06:47 PM Uhr:
> 
>> Attached is a new version (v1) of this RFC.
> 
> Here is the patch.

Excellent work!

I tested both the regular function and the fallback, both produce the
same hmac.

I only ask myself why you wrapped the last hmac calculation with
bin2hex(pack()).

Reading this:
http://www.php.net/manual/en/function.mhash.php#27225

it seems sufficient without these additional calls.


Besides that:

+1 by reading and testing.


Would be great to have that in 4.4 (and if it were my decision also 4.3
but of corse Oliver has to decide).

Regards Helmut

Regards Helmut