[TYPO3-core] RFC: Bug #11005: Browse Links Popup shows no files when all file types are allowed

Jeff Segars jsegars at alumni.rice.edu
Fri Apr 16 20:19:40 CEST 2010


On 4/15/10 8:10 AM, Jeff Segars wrote:
> On 4/15/10 7:56 AM, Dmitry Dulepov wrote:
>> Hi!
>>
>> Jeff Segars wrote:
>>> Solution:
>>> Modify the browse links class to convert the wildcard parameter into an
>>> empty string which will show all files.
>>
>> +1 by reading and testing. The patch is not made against the TYPO3
>> root, so
>> it has to be applied from inside the typo3/ directory.
>>
>>> Additional Notes:
>>> #1 - I'm attaching a test extension that modifies the images field in
>>> tt_content to allow all file types.
>>
>> For some reason it depends on 'tx' :)
>>
>>> #2 - An alternative approach would be to patch
>>> t3lib_div::getFilesInDir() to accept a wildcard character or empty
>>> string. We could also patch the the code that creates the URL for the
>>> browse links popup, but I think both of these options are more invasive
>>> so I feel little safer with the current patch
>>
>> I agree.
>>
>
> Dang, I can't even complain about a late night since I posted this at
> 3:04 my time :) Will post updates for both later today. Thanks for the
> review, even with a messy patch and text extension.

Updated patch to apply from TYPO3 root and text extension to not require 
the mysterious "tx" extension :)


-------------- next part --------------
A non-text attachment was scrubbed...
Name: test_filetypes_v2.t3x
Type: application/octet-stream
Size: 2461 bytes
Desc: not available
URL: <http://lists.typo3.org/pipermail/typo3-team-core/attachments/20100416/17ff5f57/attachment-0001.obj>
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: 11005_v3.diff
URL: <http://lists.typo3.org/pipermail/typo3-team-core/attachments/20100416/17ff5f57/attachment.txt>


More information about the TYPO3-team-core mailing list