[TYPO3-core] RFC #13732: External URL only indexes first page [indexed_search]

[Jeff Segars]

On 3/23/10 5:22 AM, Xavier Perseguers wrote:
> Hi,
>
>> I am +1 to your patch by reading. After it is committed I am going to
>> rework my patch to include your code.
>>
>> There are two small things that I did not like about the patch. May be
>> you can have a look at them:
>> - HTML parse is quite huge to get just<base>. May be a simple regular
>> expression can be better? /<base[^>]+href="([^"]+)/i should do the trick.
>> - there are two return statements. If I remember correctly, only one
>> should be in the function.
>
> I used same methodology as other part of the code but I agree this is
> suboptimal. Will change this to some simple regular expression instead
> while committing.
>
>> These two issues do not look major to me, therefore I am still willing
>> to give +1 to the current version of the patch.
>
> Are +1 by testing required? If so, anyone willing to test?
>

+1 on testing by crawling a TYPO3 site with baseURL in use (which worked 
before the patch) and a site using absolute links prepended with a slash 
(which did not work before the patch).

Thanks,
Jeff