[TYPO3-core] RFC #14087 : Feature: Allow nested GET-params in config.linkVars

Dmitry Dulepov dmitry.dulepov at gmail.com
Tue Apr 13 09:05:52 CEST 2010


Hi!

Frederick Stierle wrote:
> Solution:
> Implement functionality in class tslib_pagegen

I did not try the patch but I am a little afraid of one line:

+			$GLOBALS['TSFE']->newCObj();

This would override existing $this->cObj if that was set earlier. So any data in that cObj will be lost. Wouldn't it be better to make a local instance?

This is not a -1 but a question.

Another note. Since you change this part, could it be extracted to a separate smaller method? Currently the function with this code is 150 lines long. We could make it smaller and more readable by extracting this code to another function and call this function.

-- 
Dmitry Dulepov
TYPO3 expert / TYPO3 security team member
Read more @ http://dmitry-dulepov.com/


More information about the TYPO3-team-core mailing list