[TYPO3-core] RFC: #13698: Add proxy for the mail() function
Oliver Klee
typo3-german-02 at oliverklee.de
Mon Apr 12 23:33:27 CEST 2010
Hi,
no +1 or -1 yet, just some suggestions:
- what about some unit test? (IIRC, this function is intended for unit
testing, so this really calls for unit tests)
- some CGL issues
- please use an @see for the function comment instead of the text after
each @param
- "ret" is not a good variable name :-)
- please undo this change: self::sysLog -> t3lib_div::sysLog
- in the function documentation comment, please describe (in the first
sentence) what the function does, including which hooks it uses
Oli
--
Certified TYPO3 Integrator | TYPO3 Security Team Member
More information about the TYPO3-team-core
mailing list