[TYPO3-core] RFC: #13952: Hookrequest - t3lib_page::getPageOverlay

Benjamin Mack benni at typo3.org
Sun Apr 11 15:40:45 CEST 2010


Hey Andreas,

valid question. For hooks, my reviews look like this:

* I see what the poster wants to achieve with this hook
* I study the source code before and after, and see if there are other 
ways to solve his/her original problem
* I see if it wouldn't fit better somewhere else or if this is *really* 
the right spot
* I check the added lines in the patch, see for enough parameters that 
are handed to the hook function.

and then we have a "+1 by reading".

All the best,
benni.


More information about the TYPO3-team-core mailing list