[TYPO3-core] RFC #13998: Introduce Automatic versioning of CSS and JS files

[Georg Ringer]

Hi,

Am 06.04.2010 10:31, schrieb Lars Houmark:
> Maybe there should be a general configuration for BE and FE usage of
> this, I am looking forward to feedback :)

+1 on reading with some questions:

- why not shipping/modifing the .htaccess with the patch, as there are
already some htacceess files in typo3/
- CGL: comments are intended one addtional tab
- code
-------------------------------------
+			if ($lookupFile[1]) {
+				$separator = '&';
+			} else {
+				$separator = '?';
+			}
-------------------------------------
could be just a $seperator = ($lookupFile[1]) ? '&' : '?';
IMO this is also faster

- $fullName .= $lookupFile[1] ? '?'. $lookupFile[1] : '';
                                  ^^^ missing a space

- useInfileVersionNumbering => wouldn't be a fileVersionNumbering or
versionNumberedFiles be better?

sorry for the nitpicking
Georg