[TYPO3-core] RFC #12066: Code cleanup: Add some constants

[Oliver Klee]

Hi,

Benjamin Mack schrieb:
> so, I see you have enough +1s, so it's ready to commit.

Great! I've attached the reworked three patches.

> Please update your patch (once more, sorry):
> 
>  * One patch with the actual constants *in* config_default.php (no
> require_once, as this would slow down the pagegeneration as well)
> 
>  * One patch with the tests,
> 
>  * and one patch with all the replacements.

I've moved the constants now from a separate file to t3lib_div.
config_default wouldn't have worked because index_ts.php and init.php
include the files in this order:

0. timetracker (only index_ts)
1. t3lib_div
2. t3lib_extgmg
3. then config_default

So the three patches are like this:

1. t3lib_div with the new constants and its usage in t3lib_div, NEWS.txt
2. changes to the tests
3. usage of the constants in the core

The following parts of the core have not been changed:

- external sysexts: extbase, fluid, dbal
- typo3/contrin
- embedded JavaScript
- adodb
- openid/lib

> I will take care of the commit then.

Thanks,


Oli
-- 
Certified TYPO3 Integrator | TYPO3 Security Team Member
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 12066-v5-div.diff
Type: text/x-patch
Size: 13499 bytes
Desc: not available
URL: <http://lists.typo3.org/pipermail/typo3-team-core/attachments/20100406/52bca166/attachment-0003.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 12066-v5-tests.diff
Type: text/x-patch
Size: 3707 bytes
Desc: not available
URL: <http://lists.typo3.org/pipermail/typo3-team-core/attachments/20100406/52bca166/attachment-0004.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 12066-v5-use-in-core.diff
Type: text/x-patch
Size: 208905 bytes
Desc: not available
URL: <http://lists.typo3.org/pipermail/typo3-team-core/attachments/20100406/52bca166/attachment-0005.bin>