[TYPO3-core] RFC #13487: bugfix: no alternative icon returned from 'getIcon' in class.t3lib_iconworks.php (backend-redesign)

[Xavier Perseguers]

FYI, v2 was committed after reading and testing

- trunk (rev. 7241)
- 4-3 (rev. 7242)


On 04/05/10 13:34 , Stephan N Kellermayr wrote:
> dear Xavier,
>
> thanks for your reply...sorry, i am not yet very familiar with the
> current coding rules in TYPO3. its a little bit confusing because there
> are so many different patterns. i tried to lean on to the rules i have
> found in the code which i have modified.
>
> ...where can i find more information about the currently used coding-rules?
>
> best regards, Stephan
>
> PS: the patch attached here (version2 of RFC#13487) is corrected
> according to the CGL.
>
> PPS: the patch in the last post was only for testing...Susanne asked for
> a "simple" way to reproduce the bug.
> besides this the patch contains some other issues. one of them is
> reported (http://bugs.typo3.org/view.php?id=13486), and the other
> modifications are just a hardcoded solution to get the new
> t3xskin-extension to work.
>
> btw: ...do you know another way to extend the function 'getIcon'?
> i am not happy with the solution to replace the file
> 't3lib/class.t3lib_iconworks.php' with a hardcoded patch, but i did not
> see another way to add a new iconstate for 'Hide in Menu' (which can
> occur at all types of pages).
>
>
>
> Xavier Perseguers schrieb:
>> Hi Susanne / Stephan,
>>
>>> thanks for the explanation and testing instructions.
>>>
>>> +1 by reading and testing.
>>>
>>> BTW please add the missing spaces (CGL) around the concatenations.
>>
>> I will have a look. There's multiple patches here without version
>> number. Could you please point me out which patch(es) should be tested
>> and hopefully committed?
>>
>> I'll take care of the CGL while committing if testing is OK. By
>> reading, it is OK but for the (multiple) CGL issues (not only missing
>> spaces):
>>
>> - @coauthor does not exist in phpDoc and we don't introduce @author
>> anyway for methods
>> - $futuretiming should be $futureTiming
>> - tab found instead of space before opening brace in a "if"
>> - use of == instead of === for string comparison
>>
>> That's for the latest patch.
>>
>> For the first one :
>>
>> - missing spaces around concat operator
>> - tab found instead of space before opening brace in a "if"
>>
>


-- 
Xavier Perseguers
http://xavier.perseguers.ch/en