[TYPO3-core] RFC: Bug #11903: Use separate tables for tags in the caching framework
Martin Kutschker
masi-no at spam-typo3.org
Sat Sep 26 18:34:55 CEST 2009
Martin Kutschker schrieb:
> Oliver Hader schrieb:
>> Hi Steffen,
>>
>> Steffen Kamper schrieb:
>>> Hi olly,
>>>
>>> following notes:
>>> * unit tests doesn't work, 6 failures in testsuite
>> Ok, I fixed them to work with again... however, they are not complete.
>>
>>> While testing, the writing works as expected.
>>> Clearing cache does the clearing, but i get a MySQL error:
>>>
>>> ['lastBuiltQuery'] =>
>>> 'TRUNCATE '
>>> ....
>> That happens when no tagsTable is set. And it would have happened if not
>> cacheTable was set. It's now checked in the contructor.
>>
>> Attached is a new version with these changes:
>> * fixed bug in garbage collector concerning removal of entries without tags
>> * added contructor check for cacheTable and tagsTable
>> * modified unit tests
>
> I know that the patch is in but yet a -1 from me. Why? Because the patch sneaks in a new feature of
> t3lib_db. This should have been a separate RFC. The reason is that the new feature
> DELETEmultipleTablesQuery() isn't DBAL save.
Another reason is that there is no separate line in the Changelog for it.
Masi
More information about the TYPO3-team-core
mailing list