[TYPO3-core] RFC #9355: Add an error and exception handler (backported from FLOW3)
Rupert Germann
rupi at gmx.li
Fri Sep 25 19:38:26 CEST 2009
hi,
here's v7 containing the following changes
- removed the following files as they are not used/needed:
class.t3lib_exception.php
class.t3lib_error_error.php
class.t3lib_error_exception.php
class.t3lib_error_warning.php
- functions handleException() in
t3lib_error_DebugExceptionHandler and in
t3lib_error_ProductionExceptionHandler are indentical, so I moved them
to t3lib_error_abstractexceptionhandler. that replaces the original
function whose output was never used.
- changed the default value to E_ALL ^ E_NOTICE ^ E_WARNING
- added some error numbers to the field description of exceptionalErrors
- added a possibility to disable the exceptionhandler in BE, too. (by
unsetting exceptionHandler)
- moved the call to set_error_handler() from contructor to function
setExceptionalErrors()
- renamed function setExceptionalErrors() to
setErrorHandlerForExceptionalErrors()
- added some error numbers to fied description of exceptional errors
- removed the FLOW paths in debugexceptionhandler
- added errorlevel check in function handleError() to prevent it from
outputting something on masked errors (@)
greets
rupert
Oliver Hader schrieb:
> Great & thanks for your work on this.
>
> Here are some remarks:
> * E_ALL&~(E_NOTICE|E_WARNING) -> E_ALL ^ E_NOTICE ^ E_WARNING
> * E_ALL&~E_NOTICE -> E_ALL ^ E_NOTICE
> * Unresolved backported FLOW3 issues:
> + t3lib_error_AbstractExceptionHandler defines with handleException()
> but has no functionality - did I miss something
> + t3lib_error_DebugExceptionHandler::echoExceptionWeb() checks against
> FLOW3's 'Packages/' in the file path
> + t3lib_error_DebugExceptionHandler::echoExceptionWeb() has a link to
> typo3.org/go/exception/... that points to a FLOW3 message - I think we
> should comment that out and add a "@todo" until we have own additional
> messages there
>
> I suggest that we mark these unused FLOW3 parts with a proper "@todo"
> and re-check them later on or remove them completely.
>
> Besides that:
> +1 on reading and testing
>
> olly
More information about the TYPO3-team-core
mailing list