[TYPO3-core] FYI #11925: TCEforms suggest fails with PHP fatal error

[Oliver Hader]

Hi,

Martin Kutschker schrieb:
> Martin Kutschker schrieb:
>> Rupert Germann schrieb:
>>> Martin Kutschker schrieb:
>>>> Rupert Germann schrieb:
>>>>> Solution:
>>>>> see attached patch
>>>>>
>>>>> - $this->params['value']
>>>>> + $params
>>>> I fail to see why this solves the issue.
>>> failed by reading the code or by reading the patch? ;)
>> The patch. The solution is non-obvious as it is not clear why called
>> function queryTable() when called with $params will get the value it
>> expects. Before it was $this->params['value']!!!
> 
> If you hadn't committed this one already I would have given you a -1 for
> that reason.

I see, the patch doesn't tell anything about that and a good description
would have been nice.

The changes were done in the method
| public function queryTable(&$params, $recursionCounter = 0) {
There you see the $params veriable that is used.

+1 on reading

olly
-- 
Oliver Hader
TYPO3 Release Manager 4.3