[TYPO3-core] FYI #11925: TCEforms suggest fails with PHP fatal error

Martin Kutschker masi-no at spam-typo3.org
Fri Sep 11 15:54:20 CEST 2009


Rupert Germann schrieb:
> Martin Kutschker schrieb:
>> Rupert Germann schrieb:
>>> failed by reading the code or by reading the patch? ;)
>>
>> The patch. The solution is non-obvious as it is not clear why called
>> function queryTable() when called with $params will get the value it
>> expects. Before it was $this->params['value']!!!
> 
> absolutely right - reading only the patch does neither explain the
> problem nor the solution. Some patches require a bit of code reading.

No poblem with that. But when when this is the case a nonchalant
"Solution: see attached patch" is hardly sufficient.

Masi


More information about the TYPO3-team-core mailing list