[TYPO3-core] RFC: #11884: User setup: buttons for create/delete ENABLE_INSTALL_TOOL-file are not integrated in user setup

Oliver Hader oliver at typo3.org
Mon Sep 7 10:44:01 CEST 2009


Hi Steffen,

Steffen Kamper schrieb:
> Hi,
> 
> this is an SVN patch request.
> 
> Type: Bugfix
> 
> Bugtracker references:
> http://bugs.typo3.org/view.php?id=11884
> 
> Branches: trunk
> 
> since 0011404 user setup allows type="user", so move the button to
> admin-section of user setup

+ 	/**
+	 *
+	 * @param $params   config of the field
+	 * @param $ref      this class as reference
+	 * @return string	html with description and button
+	 */
+	public function renderInstallToolEnableFileButton($params, $ref) {

Please use proper types in PHPdoc comment and method signature, e.g.

renderInstallToolEnableFileButton(array $parameters,
SC_mod_user_setup_index $parent)

Besides that, please use if/else block instead of ($condition ? ... :
...) block.

Thanks!

olly
-- 
Oliver Hader
TYPO3 Release Manager 4.3


More information about the TYPO3-team-core mailing list